[X] My Assistant

Oh, this thing works very well. Thanks for the extension. (IMG:[invalid] style_emoticons/default/smile.gif)

New MM feature is cool, good job.

However...

2. Open the userscript in Tampermonkey to view the edit interface, then click the "settings" tab and untick "check for updates". This should make it manual update.
Sorry, I cannot help with this.

2) is probably the issue, I will change it.

Apparently unticking the "check for updates" doesn't make it manual update, but automatic update without confirmation.

Because from one day to another the MM part of the script appeared by itself without any intervention (IMG:[invalid] style_emoticons/default/laugh.gif)...

Apparently unticking the "check for updates" doesn't make it manual update, but automatic update without confirmation.

Because from one day to another the MM part of the script appeared by itself without any intervention (IMG:[invalid] style_emoticons/default/laugh.gif)...

Cannot reproduce. I have waited for a few days after rolling back my installation to the previous 2.0.5 version and making it manual update, and it is not automatically updated. It looks like Tampermonkey is not working properly on your end.

Just a heads up on something. This is a really uncommon situation, so I'm only really pointing it out in case there's an underlying issue that might matter.

On this gallery http://ehentaihip.com/g/1661888/30d1e161b1/

There's a (was, might be gone by the time you read this) spam comment showing as undefined. The spam comment is a bunch of links in html

What the comment is (I don't recommend clicking any of those links): [pastebin.com] https://pastebin.com/jd4hQmfA

What it looks like with the script enabled:


As I said, I wouldn't expect you to change anything just to view this kind of ridiculous comment, but wanted to bring it to your attention in case it's a problem that may cause issues elsewhere

Just a heads up on something. This is a really uncommon situation, so I'm only really pointing it out in case there's an underlying issue that might matter.

On this gallery http://ehentaihip.com/g/1661888/30d1e161b1/

There's a (was, might be gone by the time you read this) spam comment showing as undefined. The spam comment is a bunch of links in html

What the comment is (I don't recommend clicking any of those links): [pastebin.com] https://pastebin.com/jd4hQmfA

What it looks like with the script enabled:


As I said, I wouldn't expect you to change anything just to view this kind of ridiculous comment, but wanted to bring it to your attention in case it's a problem that may cause issues elsewhere

EH itself solves a lot of problems with that already. The comment got properly HTML quoted when displayed so nothing looking at the DOM should be able to interpret it as valid HTML

EH itself solves a lot of problems with that already. The comment got properly HTML quoted when displayed so nothing looking at the DOM should be able to interpret it as valid HTML

Yeah I checked without the script. I'm only mentioning it to mayriad in case whatever broke his script on that comment might also be something that breaks somewhere else. If it doesn't, then all's good

Yeah I checked without the script. I'm only mentioning it to mayriad in case whatever broke his script on that comment might also be something that breaks somewhere else. If it doesn't, then all's good

Thanks for the bug report. I investigated in the wrong direction but eventually it did help me find a tiny but critical bug where a gallery comment will become "undefined" when the program detects a URL that should not be parsed. It is a one line fix. I will push a patch update later today to fix some tiny bugs and address the layout change in gallery view.

This spam is indeed quite unusual. I was wondering which part of the pastebin was the spam comment before I read ero-onizuka's comment in the comment cleanup thread. Also, who would sell replica Hublot watches on EH?

Patch update: Mayriad's EH Master Script v2.1.1

## Changelog

Design fixes:

- Added an automatic redirect to a working search page when searching for an uploader whose username contains a forward slash, because the username is not encoded and the site will interpret the slash as part of the URL and return 404 not found.

Subjective fixes:

- Added the case where sending a new PM returns an error to the sub-feature that adds sent PMs to sent items and tracks these messages by default.

Comment and forum filters:

- Fixed a tiny bug where comments, posts, and thread titles with multiple user-defined keywords stop this feature from working.

Vigilante thread links:

- Adjusted CSS since the layout of the gallery information panel has changed a bit.

- Fixed the layout when there is an advertisement taking additional space above these links.

Alternative rating system:

- Adjusted the appearance very slightly, and added display for the case where, for some reason, the star rating is not a number.

Clickable external URLs:

- Fixed a tiny bug where a gallery comment will become "undefined" when the program detects a URL that should not be parsed.

Cannot reproduce. I have waited for a few days after rolling back my installation to the previous 2.0.5 version and making it manual update, and it is not automatically updated. It looks like Tampermonkey is not working properly on your end.

I don't know what to tell you.

Today I got a notification of an update for the new 2.1.1 version.
And the page says I have the 2.1.0 version installed.

Again, I didn't update the script to 2.1.0 myself, nor I got any popup. The last update I'm sure of was the 2.0.5 it did by itself without asking.
It updated by itself several times without noticing me, again.

But for some reason 2.1.1 toggled a notification again.


As of now I didn't manage to update (clicking the button wasn't working) to 2.1.1 yet.

I noticed a problem on the 2.1.0 version
edit: okay I managed to update to 2.1.1 by opening the update url directly in a new tab. Problem is NOT fixed. It persists.

Bolded (bbcode tag) external links will link to the site with a "</strong>" string after them


Gallery Link: http://ehentaihip.com/g/1540442/7379eded77/
(uploader comment)

I will check if your recent fix for another issue fixes it when I update to 2.1.1 or not, then let you know (IMG:[invalid] style_emoticons/default/smile.gif)



This post has been edited by Juggernaut Santa: Jun 18 2020, 17:46

Phew, finally got some time to do stuff on EH. Will go back to renaming next.

I don't know what to tell you.

Today I got a notification of an update for the new 2.1.1 version.
And the page says I have the 2.1.0 version installed.

Again, I didn't update the script to 2.1.0 myself, nor I got any popup. The last update I'm sure of was the 2.0.5 it did by itself without asking.
It updated by itself several times without noticing me, again.

But for some reason 2.1.1 toggled a notification again.
As of now I didn't manage to update (clicking the button wasn't working) to 2.1.1 yet.

I noticed a problem on the 2.1.0 version
edit: okay I managed to update to 2.1.1 by opening the update url directly in a new tab. Problem is NOT fixed. It persists.

Wow, your Tampermonkey sounds completely broken. I do not think I can help, sorry.

Bolded (bbcode tag) external links will link to the site with a "</strong>" string after them


Gallery Link: http://ehentaihip.com/g/1540442/7379eded77/
(uploader comment)

I will check if your recent fix for another issue fixes it when I update to 2.1.1 or not, then let you know (IMG:[invalid] style_emoticons/default/smile.gif)

Thank you for the bug report. Indeed, I did not consider URLs surrounded by tags. I have added 3 characters of code to fix it at the next update. However, parsing HTML with regex is a brave act, so I would not be surprised if this feature breaks again somewhere else.

Great Script,
It works with FF tampermonkey at least for me.
I have a couple of suggestions and improvements that might be good for it if you can do it. If not, it is also OK.

1- If you can integrate below scripts to your script so that the functionality will be better and since the code is already present, it should be easy enough.

E-Hentai - Color Results By Tags - [greasyfork.org] https://greasyfork.org/en/scripts/380614-e-...results-by-tags

e-hentai and E-Hentai Cross Links on Gallery Pages - [greasyfork.org] https://greasyfork.org/en/scripts/391562-ex...n-gallery-pages

E-Hentai Show Goods - [greasyfork.org] https://greasyfork.org/en/scripts/391561-e-hentai-show-goods

2-

CODE

This feature will colour the titles and timestamps of new galleries blue and those of expunged galleries red to make them easier to spot.

if you can make this blue and red colors custom or adjustable with custom user CSS.

3- On the gallery page, putting a download button like in the main page. the

CODE

Archive Download

button uses js popup and very inconvenient.

4- Ability to assign star ratings to galleries from the main page.

5- The additional filters are very smart thing. If you can add an ability to filter some tags it would be better.
Like an option like this.

Hide the galleries with this tag "user input" (AND/OR boolean operates can be used)

I know this can be done with the search field but the ability to filter off and on common used tags on the fly is very convenient.

Thanks anyway for sharing your private script.

TL;DR: Sadly, no, your suggestions are not viable.

It works with FF tampermonkey at least for me.

Yes, it is expected to work on Firefox as long as you load it with Tampermonkey.

1- If you can integrate below scripts to your script so that the functionality will be better and since the code is already present, it should be easy enough.

I cannot just randomly "integrate" other people's scripts. None of them has a licence so technically they are not open-source and I cannot legally "integrate" the code. Also, having the code out there does not mean it will be easy to use it; programming is not copy and paste. For example, the second script below seems unnecessarily long and complicated and I would rather code it myself.

E-Hentai - Color Results By Tags - [greasyfork.org] https://greasyfork.org/en/scripts/380614-e-...results-by-tags

I do not think this is a good idea in the first place. It will be pretty random when a gallery has multiple tags.

e-hentai and E-Hentai Cross Links on Gallery Pages - [greasyfork.org] https://greasyfork.org/en/scripts/391562-ex...n-gallery-pages

This is basically one of the features I removed before the v2.0.0 public release. Features like this will not be added (back).

E-Hentai Show Goods - [greasyfork.org] https://greasyfork.org/en/scripts/391561-e-hentai-show-goods

This is unnecessary. You just need to go to the exchanges or bookmark those links. It seems really niche and indeed this script only has 18 total downloads.

2-

CODE

This feature will colour the titles and timestamps of new galleries blue and those of expunged galleries red to make them easier to spot.

if you can make this blue and red colors custom or adjustable with custom user CSS.

I think this is unnecessary, too, and it would be better to keep it standardised.

3- On the gallery page, putting a download button like in the main page. the

CODE

Archive Download

button uses js popup and very inconvenient.

I considered this back then but had enough reasons not to do it:
- Doing so will place the download button on the category button and thus block the "search this category" behaviour.
- I do not want to place the button elsewhere because that is inconsistent, and there is no place left when other features are enabled. I am not going to add a feature to overhaul the layout.
- I think there is no real need. If you are only downloading a few galleries this way, then such a shortcut is trivial; if you are downloading a lot of galleries this way, you are doing it wrong.

4- Ability to assign star ratings to galleries from the main page.

This is obviously bad behaviour that I cannot encourage. It will never be added.

5- The additional filters are very smart thing. If you can add an ability to filter some tags it would be better.
Like an option like this.

Hide the galleries with this tag "user input" (AND/OR boolean operates can be used)

That is the tag filtering we already have, right? You should be asking Tenboro for improvements. I doubt there is a need for complex rules, though.

I know this can be done with the search field but the ability to filter off and on common used tags on the fly is very convenient.

Not a good idea. Assuming you are talking about the existing tag filter, switching on/off the filter can significantly alter search results even if you are on page 1, and you may suddenly find yourself lost after the switch; it will not work like you imagined. If you are talking about a client-side tag filter that can instantly hide or show galleries without reloading the page, you are asking me to redo Tenboro's work.

This post has been edited by mayriad: Jul 17 2020, 23:09

Ayyy

Is it possible to add a function that copies the title of the downloading file(if it is a torrent file) to the clipboard? The naming system of each torrent varies by their uploader, which is bad for both classification and storage and I have to correct them one by one(which means copy the title manually and then paste it). It will be much nicer if the script can automatically do it for me.

I have tried to edit the script by myself, but no luck so far...

Ayyy

Is it possible to add a function that copies the title of the downloading file(if it is a torrent file) to the clipboard? The naming system of each torrent varies by their uploader, which is bad for both classification and storage and I have to correct them one by one(which means copy the title manually and then paste it). It will be much nicer if the script can automatically do it for me.

I have tried to edit the script by myself, but no luck so far...

Sorry for late response. I am too busy in real life.

If I understand correctly, you want to copy the gallery title to clipboard when you download a torrent from that gallery? Are you aware that you cannot directly rename the actual gallery file until the torrent is fully downloaded? Even if I add this feature, you will still need to paste the titles in a big list, and then manually copy and paste the titles to rename the files after they are downloaded.

Therefore, I think what you are proposing is pretty useless in the first place. Furthermore, this is a weird feature which hopefully no one else needs, and I cannot add something just because one user wants it.

If you care about the names of your downloads, use a library manager like [github.com] LANraragi to automatically import and rename your files, or download archives instead.

Patch update: Mayriad's EH Master Script v2.1.2

## Changelog

Scientific dark theme:

- Added styles for the new expunge system.

- Added styles for brighter text on the expunge and rename trackers. Firefox has a render problem that I have mostly avoided using some hardcoded styles, but revoked expunge petitions will still have a suboptimal appearance on the tracker.

- Added a colour style for the gallery ranking table on the public gallery statistics page.

Scientific light theme:

- Added styles for the new expunge system.

Design fixes:

- Added code to fit images in forum posts to screen width.

- Added a style to cancel an existing inline style and let submitted rename titles wrap to next line on the rename tracker to prevent long titles from extending the page.

- Fixed incorrect application of a fix to a table on the public gallery statistics page.

- Disabled the fix for ponies, because it has been discovered that the adjustment needed differs by pony, browser and gallery list type, and it is too difficult to fix the ponies completely.

Gallery colour coding:

- Added code to bold the titles of new galleries in addition to making them blue, for further visual enhancement and better consistency with the timestamps.

Clickable external URLs:

- Added 3 characters of code to parse URLs surrounded by HTML tags.

This post has been edited by Mayriad: Oct 20 2020, 02:08

Is it possible to add a function that disable the custom scrolling mechanism in MPV
without adding horizontal bar at bottom of page.


currently using this script by FabulousCupcake but bottom horizontal bar is eyesore.
any solution ?

CODE

// ==UserScript==
// @name         EH - MPV Disable Custom Scroll
// @namespace    http://fabulous.cupcake.jp.net
// @version      1.0.1
// @description  Disables custom scrolling mechanism in E-Hentai multi page viewer
// @author       FabulousCupcake
// @include      /^https?:\/\/e.hentai\.org\/mpv\/\d+?\/\w+?\/.*$/
// @grant        unsafeWindow
// @run-at       document-end
// ==/UserScript==

(function() {
    'use strict';

    // Replace custom scroll with dummy function
    unsafeWindow.do_mousescroll = function() {
        return;
    };

    // Remove overflow: hidden stylesheet
    let stylesheet = `
    #pane_images {
        overflow: scroll !important;
        height: auto;
    }
    `;
    var stylesheetEl = document.createElement('style');
    stylesheetEl.innerHTML = stylesheet;
    document.body.appendChild(stylesheetEl);

    document.onkeydown = null;
})();

PENGUIN EDIT: tiny tweak (IMG:[invalid] style_emoticons/default/wink.gif)



This post has been edited by blue penguin: Oct 24 2020, 23:21

Is it possible to add a function that disable the custom scrolling mechanism in MPV
without adding horizontal bar at bottom of page.
currently using this script by FabulousCupcake but bottom horizontal bar is eyesore.
any solution ?

I think that userscript serves to keep loaded images in the MPV and show an additional vertical scrollbar? The metadata are not very descriptive. It just unnecessarily altered the entire overflow property; replace "overflow" in the code above with "overflow-y" should remove the horizontal scrollbar.

That script is a bit long, though, and forgot to adjust the width of images after adding the vertical scroll bar, which hides the right side of images a little. The MPV hotkeys were also disable even though they have nothing to do with the script's objective. Therefore, I wrote a shorter one, partially for my master script:

CODE

// ==UserScript==
// @name            EH Keep MPV Images
// @namespace       https://github.com/Mayriad
// @version         1.0.0
// @author          Mayriad
// @description     Keeps loaded images in the MPV
// @include         /e.hentai\.org\/mpv\//
// @run-at          document-end
// ==/UserScript==

;(function () {
  unsafeWindow.do_mousescroll = () => {}
  const styleText = document.createElement('style')
  styleText.textContent = `
    #pane_images { overflow-y: scroll !important; }
    .mi0 img[id ^= "imgsrc_"] { width: 100% !important; object-fit: contain; }`
  document.head.appendChild(styleText)
})()

I think that userscript serves to keep loaded images in the MPV and show an additional vertical scrollbar? The metadata are not very descriptive. It just unnecessarily altered the entire overflow property; replace "overflow" in the code above with "overflow-y" should remove the horizontal scrollbar.

That script is a bit long, though, and forgot to adjust the width of images after adding the vertical scroll bar, which hides the right side of images a little. The MPV hotkeys were also disable even though they have nothing to do with the script's objective. Therefore, I wrote a shorter one, partially for my master script:

CODE

// ==UserScript==
// @name            EH Keep MPV Images
// @namespace       https://github.com/Mayriad
// @version         1.0.0
// @author          Mayriad
// @description     Keeps loaded images in the MPV
// @include         /e.hentai\.org\/mpv\//
// @run-at          document-end
// ==/UserScript==

;(function () {
  unsafeWindow.do_mousescroll = () => {}
  const styleText = document.createElement('style')
  styleText.textContent = `
    #pane_images { overflow-y: scroll !important; }
    .mi0 img[id ^= "imgsrc_"] { width: 100% !important; object-fit: contain; }`
  document.head.appendChild(styleText)
})()

awesome man life saver

Is there a setting that blocks the title popups from working? I can't get them to work at all at this time in the Firefox extension.

Is there a setting that blocks the title popups from working? I can't get them to work at all at this time in the Firefox extension.

What do you mean by "title popups"? I cannot think of anything like that.